Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account_reversal (reversal usability improvements) #1725

Open
wants to merge 77 commits into
base: 16.0
Choose a base branch
from

Conversation

rousseldenis
Copy link

@rousseldenis rousseldenis commented Sep 19, 2023

  • Adds reversal id field

@ and others added 30 commits September 18, 2023 14:40
…ed flag and reversal_id many2one

(lp:c2c-addons/6.1  rev 5609)
… you are in December 2013 and FY 2014 is not created yet).

Add prefer_normal_period in period selection.
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
oca-transbot and others added 10 commits September 19, 2023 11:24
Currently translated at 100.0% (30 of 30 strings)

Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_reversal
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_reversal/nl/
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_reversal
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_reversal/
Migration to 16.0 by expanding core features adding:

- The line reason to reversal
- The 'To Be Reversed' field and filter
- Displaying the move reason not only for invoices
This commit adds the `reversal_id` field in order to improve
the UX of the move reversal functionality. The field has been
added to the form view close to the `reversed_entry_id` field
already present in the view.

This commit also introduces a constraint preventing the user
to flag a move as to be reversed when a non cancelled reversal
move has already been created. This allows simplifying the domain
used on the `to_be_reversed` filter.

Finally, it also convert the deprecated `SavepointCase` test
into a `TransactionCase` one.

Fixes: OCA#1761
@IT-Ideas
Copy link

Hello @rousseldenis, I just added a commit in order to fix #1761. Could you add it in the PR message?

@sbidoul sbidoul added this to the 16.0 milestone Jan 1, 2024
@sbidoul sbidoul changed the title [16.0][MIG] account_reversal [16.0][MIG] account_reversal (reversal usability improvements) May 21, 2024
After this commit, the order is
- To be reversed flag
- Reversal Entry
- Reversal of

Before, the flag was between the entries which was weird.
@sbidoul
Copy link
Member

sbidoul commented May 21, 2024

I have pushed a couple of minor fixes and clarifications.

I think it's ok to keep the module name as is to reduce migration burden for users of the module in older Odoo versions.

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 22, 2024
@github-actions github-actions bot closed this Oct 27, 2024
@sbidoul sbidoul reopened this Oct 27, 2024
@sbidoul sbidoul removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.